Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KubeIngressProxy] Add KubeIngressProxy.ingress_class_name #668

Merged
merged 1 commit into from Nov 8, 2022

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Nov 8, 2022

This allows to set ingressClassName field in ingress specification, which is important for k8s instances with multiple ingress class names allowed.

Last step of dividing #648 into smaller pieces

@consideRatio consideRatio added KubeIngressProxy KubeIngressProxy is a separate class from KubeSpawner! new labels Nov 8, 2022
@consideRatio consideRatio merged commit 4960fcf into jupyterhub:main Nov 8, 2022
@dolfinus dolfinus deleted the ingress_class_name branch November 8, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KubeIngressProxy KubeIngressProxy is a separate class from KubeSpawner! new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants