Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #657 a change with saving and restoring the namespace was added to KubeSpawner, to avoid some issues caused by Jupyterhub restart.
But
namespace
is substituted indns_name_template
, sodns_name
should be saved and restored as well.Other options in
__init__
support onlyhubnamespace
substutution, not pod namespace, so there is no need to preserve it between restart.