Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KubeIngressProxy] Do not try to escape None #731

Merged
merged 1 commit into from May 17, 2023
Merged

[KubeIngressProxy] Do not try to escape None #731

merged 1 commit into from May 17, 2023

Conversation

dolfinus
Copy link
Contributor

Fix for #723.

It seems that hub route data is {"hub": true}, but function KubeIngressProxy:_expand_user_properties try to get user from it.

@dolfinus dolfinus mentioned this pull request May 17, 2023
Closed
@consideRatio consideRatio added bug KubeIngressProxy KubeIngressProxy is a separate class from KubeSpawner! labels May 17, 2023
@consideRatio consideRatio changed the title Do not try to escape None [KubeIngressProxy] Do not try to escape None May 17, 2023
consideRatio
consideRatio approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more used to providing default values via data.get('user', '') compared to data.get('user') or '', but the latter is consistent with the other code in the function so this PR seems perfect as it is!

@consideRatio consideRatio merged commit 0c837e2 into jupyterhub:main May 17, 2023
9 checks passed
@dolfinus dolfinus deleted the ingress_escape_none branch May 17, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
bug KubeIngressProxy KubeIngressProxy is a separate class from KubeSpawner!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dolfinus @consideRatio