Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to expand callable environment variables #826

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Don't attempt to expand callable environment variables #826

merged 2 commits into from
Mar 28, 2024

Conversation

manics
Copy link
Member

@manics manics commented Mar 26, 2024 •
edited

@manics manics added the bug label Mar 26, 2024
@manics manics changed the title Add failing test for callable environment variables Don't attempt to expand callable environment variables Mar 27, 2024
@manics manics marked this pull request as ready for review March 27, 2024 21:46
@manics
Copy link
Member Author

manics commented Mar 27, 2024 •
edited

test_spawn_internal_ssl is failing on the main branch too: #828

@consideRatio consideRatio merged commit 7268a51 into jupyterhub:main Mar 28, 2024
3 of 7 checks passed
@manics manics deleted the callable-env branch March 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c.KubeSpawner.environment not interpreting callables Support for callables in env no longer works
2 participants
@manics @consideRatio