Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort Hub when reflector ultimately fails #86

Merged
merged 1 commit into from Oct 2, 2017

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 2, 2017

because this is an unrecoverable error

From this comment, this was the desired behavior, but raising an Exception in a Thread only aborts the thread, not the process.

@yuvipanda yuvipanda merged commit 1a27374 into jupyterhub:master Oct 2, 2017
@minrk minrk deleted the abort-watch-failure branch October 3, 2017 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants