Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate events_archiver_keys for AWS curvenote #2834

Merged
merged 2 commits into from Nov 22, 2023

Conversation

manics
Copy link
Member

@manics manics commented Nov 19, 2023

@manics manics force-pushed the aws-curvenote-events-archiver branch from 2fd0143 to 23f43e3 Compare November 19, 2023 23:40
@manics manics force-pushed the aws-curvenote-events-archiver branch from 23f43e3 to a0cbf5e Compare November 19, 2023 23:41
@minrk
Copy link
Member

minrk commented Nov 21, 2023

Ran terraform to create the key, put the key in secrets/config/curvenote.yaml. For the record, ran specifically:

terraform output -json events_archiver_keys | jq -r '.curvenote' | pbcopy

stored in secrets/config/curvenote.yaml as:

eventsArchiver:
  serviceAccountKey: |
    {
      "type": "service_account",

Related: it looks like there's no github client credentials set up for the curvenote deployment. That will likely hit rate limits very soon after getting significant traffic. We have not historically shared github client credentials across federation members, but I'm not sure we really need to keep them separate, if you want to copy the one for prod (especially since prod doesn't actually have a binderhub instance anymore!), that seems fine.

@manics
Copy link
Member Author

manics commented Nov 22, 2023

Thanks for the reminder about GitHub client credentials! It's best practice to rotate credentials every now and then so I'll create a new set.

@manics manics merged commit 39d8618 into jupyterhub:main Nov 22, 2023
4 checks passed
@manics manics deleted the aws-curvenote-events-archiver branch November 22, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants