add github client id, secret to common secret config #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Shouldnt we use a different key for staging and prod?
…On Oct 5, 2017 9:09 AM, "Min RK" ***@***.***> wrote:
and bump binderhub to support them (jupyterhub/binderhub#165
<jupyterhub/binderhub#165>)
------------------------------
You can view, comment on, or merge this pull request online at:
#59
Commit Summary
- add github client id, secret to common secret config
- bump binderhub
File Changes
- *M* config/common.yaml
<https://github.com/jupyterhub/mybinder.org-deploy/pull/59/files#diff-0>
(2)
- *M* config/secret/common.yaml
<https://github.com/jupyterhub/mybinder.org-deploy/pull/59/files#diff-1>
(0)
Patch Links:
- https://github.com/jupyterhub/mybinder.org-deploy/pull/59.patch
- https://github.com/jupyterhub/mybinder.org-deploy/pull/59.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#59>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAB23oTpHHJib557aoGvEo8qmqizcREWks5spP8zgaJpZM4PvVJw>
.
|
to get github token support
|
Maybe when it's doing something other than applying a rate limit. I think one token for the whole deployment makes sense for now. |
|
Cool! We can re examine if we actually start hitting the limits!
…On Oct 5, 2017 9:14 AM, "Min RK" ***@***.***> wrote:
Maybe when it's doing something other than applying a rate limit. I think
one token for the whole deployment makes sense for now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB23tXPOwy8fjU8oJvgKpXgx2nPScrUks5spQCCgaJpZM4PvVJw>
.
|
|
Sounds good. I'll deploy this to beta once staging is up and I've verified that it's using the github credentials correctly. |
|
It's working. Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and bump binderhub to support them (jupyterhub/binderhub#165)