Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs for Binder Badge w/GitHub Actions #203

Merged
merged 25 commits into from
Jul 18, 2020
Merged

Add Docs for Binder Badge w/GitHub Actions #203

merged 25 commits into from
Jul 18, 2020

Conversation

hamelsmu
Copy link

@hamelsmu hamelsmu commented Jul 17, 2020

Summary of changes made:

  • Updated conf.py while pair programming with @choldgraf, to enable MyST parser
  • Added a how-to guide for using Actions to comment on a PR with a binder badge.
  • Added dependency of myst_parser to doc-requirements.txt

Thanks to @choldgraf for pair programming with me and getting me started.

cc: @betatim

Closes #202 (added by @consideRatio)

@welcome
Copy link

welcome bot commented Jul 17, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@hamelsmu
Copy link
Author

@choldgraf stuck on this one, not sure how to resolve the readthedocs error, does anything stick out to you?

Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments but in general this is looking great!

doc/howto/gh-actions-badges.md Outdated Show resolved Hide resolved
doc/howto/gh-actions-badges.md Outdated Show resolved Hide resolved
doc/howto/gh-actions-badges.md Show resolved Hide resolved
Hamel Husain and others added 2 commits July 17, 2020 12:24
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@hamelsmu
Copy link
Author

Reposting this comment from @choldgraf as a reminder of TODO for myself:

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for a comment from anyone

@hamelsmu
Copy link
Author

hamelsmu commented Jul 17, 2020

@choldgraf

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for comment from anyone

I addressed this with another example and more explanation. I didn't want to overly complicate the issue, so I provided the building blocks of how you can achieve this with a more simple example and let the user decide what to do themselves. What do you think?

Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, there are still some open discussions not yet resolved, but other than that I think this is excellent!

I'm very happy to have learned more about GitHub actions and MyST by reviewing this excellent documentation! Excellent work @hamelsmu! ❤️ 🎉

Hamel Husain and others added 2 commits July 17, 2020 16:05
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@hamelsmu
Copy link
Author

hamelsmu commented Jul 17, 2020

@consideRatio

there are still some open discussions not yet resolved

What is not resolved? Please let me know!

@consideRatio
Copy link
Member

there are still some open discussions not yet resolved

Nothing any more, you quickly resolved them =) This LGTM! +1 for merge @choldgraf!

@hamelsmu
Copy link
Author

hamelsmu commented Jul 17, 2020

Oh wait, maybe I messed up the title of this it is not supposed to be capitalized, it seems 🤦 my apologies

EDIT: ☝️ Fixed it 🎉 LOL

@hamelsmu
Copy link
Author

@consideRatio I'm going to start calling you the "human" linter 🎉 I got to get whatever IDE plugins you are using! Sharp eye for spacing

@consideRatio
Copy link
Member

Final fix so it doesn't get lost in the big thread: #203 (review)

@hamelsmu
Copy link
Author

Final fix so it doesn't get lost in the big thread: #203 (review)

Fixed it in d72a4b2

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @hamelsmu!!! ❤️

Co-authored-by: Tim Head <betatim@gmail.com>
@choldgraf
Copy link
Member

choldgraf commented Jul 18, 2020

Alright this LGTM as well - thanks all for all of the helpful comments and iteration! And congrats @hamelsmu on figuring out how Sphinx works! You are in rarefied air 😅

Thanks for this contribution!

@choldgraf choldgraf merged commit 700ffbe into jupyterhub:master Jul 18, 2020
@welcome
Copy link

welcome bot commented Jul 18, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@choldgraf
Copy link
Member

It's alive! https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to add a "run with Binder" bot using GitHub actions
6 participants