New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circleci for flake8 #7

Merged
merged 16 commits into from Dec 6, 2018

Conversation

Projects
None yet
4 participants
@leportella
Copy link
Collaborator

leportella commented Dec 5, 2018

No description provided.

@leportella leportella force-pushed the add-circle-ci-config branch from 50dae35 to 008c039 Dec 5, 2018

@leportella leportella force-pushed the add-circle-ci-config branch from 0dee5af to 71f8974 Dec 5, 2018

leportella added some commits Dec 5, 2018

- checkout
- run:
name: Installing dependencies
command: sudo pip install -r dev-requirements.txt

This comment has been minimized.

@Carreau

Carreau Dec 5, 2018

Member

You likely want to pip install . here as well. Sudo might not be required if you use --user

This comment has been minimized.

@yuvipanda

yuvipanda Dec 5, 2018

Member

To expand a little bit:

pip install . will install package in setup.py in current directory (.). Currently the error in CircleCI seems to be:

ModuleNotFoundError: No module named 'jupyterhub'

This is because the JupyterHub package is specified as part of install_requires in setup.py, but not in dev-requirements.txt. setup.py is the correct place for it, but we should use pip to run it before testing here.

@leportella leportella force-pushed the add-circle-ci-config branch from 43a4710 to 02ccfec Dec 5, 2018

@leportella

This comment has been minimized.

Copy link
Collaborator

leportella commented Dec 6, 2018

@yuvipanda @Carreau I tried using --user but it couldn't install the modules the right way and I continued to have problems. Is it ok to keep using sudo?

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Dec 6, 2018

I think it's fine. It can maybe be worked out and removed later, but I don't think it's needed here.

@leportella

This comment has been minimized.

Copy link
Collaborator

leportella commented Dec 6, 2018

This is full of small and messy commits. Can I merge this way or is it better if I make another cleaner pull-request?

@yuvipanda

This comment has been minimized.

Copy link
Member

yuvipanda commented Dec 6, 2018

yeah, I think it's fine too.

@leportella I think it's ok to merge as is especially this early in the project.

2 similar comments
@yuvipanda

This comment has been minimized.

Copy link
Member

yuvipanda commented Dec 6, 2018

yeah, I think it's fine too.

@leportella I think it's ok to merge as is especially this early in the project.

@yuvipanda

This comment has been minimized.

Copy link
Member

yuvipanda commented Dec 6, 2018

yeah, I think it's fine too.

@leportella I think it's ok to merge as is especially this early in the project.

@leportella leportella merged commit 5cbb3db into master Dec 6, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@leportella leportella deleted the add-circle-ci-config branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment