Add circleci for flake8 #7
Conversation
leportella
force-pushed
the
add-circle-ci-config
branch
from
50dae35
to
008c039
Compare
leportella
force-pushed
the
add-circle-ci-config
branch
from
0dee5af
to
71f8974
Compare
…thenticator into add-circle-ci-config
| - checkout | ||
| - run: | ||
| name: Installing dependencies | ||
| command: sudo pip install -r dev-requirements.txt |
There was a problem hiding this comment.
You likely want to pip install . here as well. Sudo might not be required if you use --user
There was a problem hiding this comment.
To expand a little bit:
pip install . will install package in setup.py in current directory (.). Currently the error in CircleCI seems to be:
ModuleNotFoundError: No module named 'jupyterhub'
This is because the JupyterHub package is specified as part of install_requires in setup.py, but not in dev-requirements.txt. setup.py is the correct place for it, but we should use pip to run it before testing here.
leportella
force-pushed
the
add-circle-ci-config
branch
from
43a4710
to
02ccfec
Compare
|
@yuvipanda @Carreau I tried using |
|
I think it's fine. It can maybe be worked out and removed later, but I don't think it's needed here. |
|
This is full of small and messy commits. Can I merge this way or is it better if I make another cleaner pull-request? |
|
yeah, I think it's fine too. @leportella I think it's ok to merge as is especially this early in the project. |
2 similar comments
|
yeah, I think it's fine too. @leportella I think it's ok to merge as is especially this early in the project. |
|
yeah, I think it's fine too. @leportella I think it's ok to merge as is especially this early in the project. |
No description provided.