New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 error #329
404 error #329
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
When I start jupyterlab in binder for the Git Environment Repo (binder link) I go to terminal and I try to run
Am I using gitpuller wrong? Is there a way to check if nbgitpuller is working fine or not? How can I overcome this problem, I'm using MyBinder for teaching and as of now my notebooks are not working. I'd appreciate if you can help me troubleshoot the problem. |
Since everything was working fine 1 year ago, I wanted to test earlier versions of some packages. I generated alperyilmaz/gitpuller-test-binder repo as Environment Repo to test the issue. First I tried the older version of nbgitpuller, I used the following environment.yml
When I run Binder on the Environment Repo MyBinder Link, If I try to git pull a content repo MyBinder Link I get 404. Then I thought maybe the problem is not nbgitpuller but jupyterlab itself. So, I installed an earlier version (roughly one year ago, everything was running without problems). So, here's the updated environment.yml file
And, no luck. Still getting 404 if I want to pull a content repo. Then I thought, is this a problem about MyBinder site? So I found someone else's repo which uses nbgitpuller. I tried their "launch binder" button link and I saw 404 again! What's going on? What should I troubleshoot next? It has been around 8 hrs I'm struggling with this issue. I'm trying to troubleshoot but I'm failing all the time. |
@alperyilmaz -- It is probably something you cannot fix yourself. If you used the same URL as before and you've found other examples you knew to work that now don't, then it is probably an issue in how repo2docker installs something necessary for that to work or about how the proxy server involved or URL parsing works, or doesn't in this case, on the public binderhubs currently. There's a lot of infrastructure that runs MyBinder sessions that you cannot control. For troubleshooting it can be a challenge to keep track of what you may be able to fix and not. UPDATE: Someone also just reported notebooks with parameters in the URL not working for MyBinder launches succesffuly and this may all be related, too. See 'Nb on binder with parameters now resulting in 404' here. |
If I click the original link, it takes me to https://notebooks.gesis.org/binder/jupyter/user/alperyilmaz-jup-b-python-binder-la732jf3/git-pull%3Frepo=https%3A%2F%2Fgithub.com%2Falperyilmaz%2Fjupyterlab-python-intro&urlpath=lab%2Ftree%2Fjupyterlab-python-intro%2F&branch=master, which is a 404. The problem is something with url encoding - if I replace the %3F after So something isn't uri decoding correctly somewhere |
It being that subtle, lead me to investigate the case of opening RStudio from MyBinder launches further. I noticed an extra |
https://discourse.jupyter.org/t/nb-on-binder-with-parameters-now-resulting-in-404/21860 says it last worked on 2023-10-09, so I suspect jupyterhub/binderhub#1758 (edited, wrong PR), which was deployed two days ago in jupyterhub/mybinder.org-deploy#2770 might need another tweak. |
@fomightez @alperyilmaz I've reverted the change I helped deployed a couple days ago, does that fix your issue for now? |
Yay! That fixes the issues with nbparams and nbgitpuller. I'm still seeing failure to launch into RStudio directly, or even switch to RStudio from the JupyterLab launcher tile, unless you do some acrobatics. Though going to RStudio may not quite be related to what broke those two, even though the URL encoding does seem to play a part. |
Hi,
Thanks for fixing the issue. My link works now..
12 Eki 2023 Per 17:48 tarihinde Yuvi Panda ***@***.***> şunu
yazdı:
… @fomightez <https://github.com/fomightez> @alperyilmaz
<https://github.com/alperyilmaz> I've reverted the change I helped
deployed a couple days ago, does that fix your issue for now?
—
Reply to this email directly, view it on GitHub
<#329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADEH5YDOT6VDQICYR3GBTLX677KZANCNFSM6AAAAAA52EQ53Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@alperyilmaz @fomightez we've redeployed the original change, with a fix (jupyterhub/binderhub#1774). Your link continues to work for me! Can you try it out and let me know if you have problems? We're working on cleaning up the binderhub frontend code, and making it more robust (adding unit tests, refactoring, type checks, etc). This break was unfortunately a side effect of that, but hopefully the added tests and robustness will make things better in the long run - you'll see that the fix PR has more lines of test than fix! Thank you for your patience and continuing to use mybinder.org :) And thanks to @consideRatio and @manics for helping fix this! |
@yuvipanda my link works! thanks for your time and effort.. |
Bug description
The nbgitpuller fails and mybinder gives 404 Not Found error. My link was working fine last year but when I tried it now, it failed. Either something in nbgitpuller or mybinder.org has changed
How to reproduce
My link is here
I tried nbgitpuller link generator to generate the link with following info:
Git Environment Repository URL : https://github.com/alperyilmaz/jupyterlab-python-binder
Branch: main
Git Content Repository URL: https://github.com/alperyilmaz/jupyterlab-python-intro
Branch: master
Application to open: jupyterlab
Expected behaviour
My custom notebooks from content repo should be open
Actual behaviour
404 Not found error
Your personal set up
In my Git Environment Repository nbgitpuller version 1.2.0 is installed.
Package list
Configuration
# jupyterhub_config.py
Logs
The text was updated successfully, but these errors were encountered: