[Generic] Remove userdata_method configuration supposedly not relevant #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2020
consideRatio
changed the title
minrk
force-pushed
the
pr/remove-userdata_method-config
branch
from
1449d2b
to
b0a59e4
Compare
minrk
force-pushed
the
pr/remove-userdata_method-config
branch
from
b0a59e4
to
9864a13
Compare
|
Rebased and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A final piece discussed to be deprecated in #197 which I think should be closed no matter what though.
The idea is that the
userdata_methodis always going to beGET, but I'm not 100% that is true. I'm not sure how to get knowledge if this is a relevant configuration option any more though, it is like needing to proove there is no black sheeps, its hard.