Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0: Add refresh and id tokens to auth_state #393

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Auth0: Add refresh and id tokens to auth_state #393

merged 1 commit into from
Dec 14, 2020

Conversation

biomath-vlad
Copy link

Custom client libraries subclassed from this authenticator will benefit from receiving not only the access_token but also refresh_token and id_token. These token are usually provided by callback from Auth0 service.

@welcome
Copy link

welcome bot commented Dec 4, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Custom client libraries subclassed from this authenticator will benefit from receiving not only the access_token but also refresh_token and id_token.  These token are usually provided by callback from Auth0 service.
@biomath-vlad biomath-vlad marked this pull request as draft December 4, 2020 02:21
@minrk minrk marked this pull request as ready for review December 14, 2020 09:53
@minrk minrk merged commit 6f239be into jupyterhub:master Dec 14, 2020
@welcome
Copy link

welcome bot commented Dec 14, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk minrk changed the title Return refresh and id tokens from authenticate Auth0: Add refresh and id tokens to auth_state Dec 14, 2020
@minrk
Copy link
Member

minrk commented Dec 14, 2020

Seems sensible, thanks!

@biomath-vlad biomath-vlad deleted the return-refresh-and-id-tokens-from-authenticate branch December 15, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants