Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure oauthenticator.tests is packaged #407

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Ensure oauthenticator.tests is packaged #407

merged 2 commits into from
Feb 4, 2021

Conversation

manics
Copy link
Member

@manics manics commented Jan 28, 2021

This ensures you can import the test infrastructure when developing external authenticators that have this as a dependency.

See #406 (comment)

@manics manics mentioned this pull request Jan 28, 2021
Closed
consideRatio
consideRatio approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@consideRatio
Copy link
Member

@minrk this is fine, right? I don't know what I don't know, but believe this is unproblematic. Agree?

@consideRatio
Copy link
Member

consideRatio commented Feb 1, 2021 •
edited
Loading

A person asked for a release. Okay to cut 0.13.0 with this included, the changelog entry is currently...

#### Enhancements made

* Auth0: Add refresh and id tokens to auth_state [#393](https://github.com/jupyterhub/oauthenticator/pull/393) ([@biomath-vlad](https://github.com/biomath-vlad))

#### Bugs fixed

* PyJWT 2.0 compliant [#402](https://github.com/jupyterhub/oauthenticator/pull/402) ([@rragundez](https://github.com/rragundez))

yuvipanda
yuvipanda reviewed Feb 3, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@yuvipanda yuvipanda merged commit fa73290 into jupyterhub:master Feb 4, 2021
@yuvipanda
Copy link
Collaborator

Thanks, @manics!

@manics manics deleted the package-tests branch February 4, 2021 11:04
@consideRatio consideRatio mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda left review comments

@consideRatio consideRatio consideRatio approved these changes

@minrk minrk Awaiting requested review from minrk

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manics @consideRatio @yuvipanda