Adjust the params of the access token request when basic auth is enabled #568
Conversation
|
@GeorgianaElena is this a bugfix of a regression introduced in the refactoring PR, or something different or more? |
GeorgianaElena
force-pushed
the
fix-req-headers
branch
from
a8baee5
to
4b882a2
Compare
|
Ah, I think I understand thanks to excellent summaries in referenced issues! Before refactoring PR we had a bug |
|
I think it's more. I believe, according to #273, the GenericOAuthenticator (and possibly other oauthenticators also) wasn't including the client creds in the request at all. So, the refactor, added the creds to the request for all authenticators, but didn't take into account the basic_auth thing. So, now this fixes that. I believe labeling it as a bug, is enough? Anyway, after we get #561 merged, I will focus on documenting the refactorization as best as I can, so we can make a release and see if it actually broke more things than expected 😬 |
Fixes #565