Skip to content

Commit

Permalink
Merge pull request #963 from manics/lab-no-minimize
Browse files Browse the repository at this point in the history
MRG: Disable jupyterlab extension build minimize
  • Loading branch information
minrk committed Sep 18, 2020
2 parents 8fe5916 + 45eccfe commit 09a4cfb
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions repo2docker/buildpacks/conda/install-miniforge.bash
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@ conda env create -p ${NB_PYTHON_PREFIX} -f /tmp/environment.yml
# This will install and enable the extension for jupyter notebook
${NB_PYTHON_PREFIX}/bin/python -m pip install jupyter-offlinenotebook==0.1.0
# and this installs it for lab. Keep going if the lab version is incompatible
# with the extension
${NB_PYTHON_PREFIX}/bin/jupyter labextension install jupyter-offlinenotebook || true
# with the extension.
# Don't minimize build as it may fail, possibly due to excessive resource usage
# https://discourse.jupyter.org/t/tip-binder-jupyterlab-extension/6022
# https://discourse.jupyter.org/t/jupyter-lab-build-hangs-and-then-fails-at-webpack-config-webpack-prod-minimize-config-js/6017/3
${NB_PYTHON_PREFIX}/bin/jupyter labextension install --no-build jupyter-offlinenotebook && \
$NB_PYTHON_PREFIX/bin/jupyter lab build --minimize=False || \
true

# empty conda history file,
# which seems to result in some effective pinning of packages in the initial env,
Expand Down

0 comments on commit 09a4cfb

Please sign in to comment.