MRG: Disable jupyterlab extension build minimize #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
added a commit
to manics/temporary-repo2docker-conda-test
that referenced
this pull request
Sep 18, 2020
Merged
manics
changed the title
|
Sounds good to me, with my dangerous half knowledge of the jupyter lab build process. What is the disadvantage of removing the "minimize" step? |
Should be some increased cost of loading jupyterlab javascript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyterhub/mybinder.org-deploy#1607
${NB_PYTHON_PREFIX}/bin/jupyter labextension install jupyter-offlinenotebook || truesometimes fails. This may be due to excessive memory usage by the default build minimize step:This PR disables the minimize step.