Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always unpack a single zenodo zip #1043

Merged
merged 1 commit into from
Jul 6, 2021
Merged

always unpack a single zenodo zip #1043

merged 1 commit into from
Jul 6, 2021

Conversation

akhmerov
Copy link
Contributor

Closes #1042 (see discussion there).

@welcome
Copy link

welcome bot commented May 27, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@akhmerov
Copy link
Contributor Author

Docs failure is unrelated :(

@yuvipanda
Copy link
Collaborator

If you add a test pointing to an appropriate zenodo DOI that will be extracted, am happy to merge this!

If you rebase, the docs failure should be gone now

@akhmerov
Copy link
Contributor Author

akhmerov commented Jul 6, 2021

Please take a look, I've rebased and adjusted an existing test.

@yuvipanda yuvipanda merged commit f07111c into jupyterhub:master Jul 6, 2021
@welcome
Copy link

welcome bot commented Jul 6, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@yuvipanda
Copy link
Collaborator

\o/ thanks a lot, @akhmerov! I'll try deploy this later today

@yuvipanda
Copy link
Collaborator

@akhmerov deployed now! Can you test it out?

@akhmerov
Copy link
Contributor Author

akhmerov commented Jul 6, 2021

Yep, works just as expected! Thanks!

@yuvipanda
Copy link
Collaborator

Thanks a lot, @akhmerov!

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/possible-to-unpack-zenodo-zip-files-from-manually-preserved-zenodo-archives/9798/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always unpack single zip files from Zenodo
3 participants