Bump version of RStudio available in repo2docker #1099
Conversation
- 1.3 isn't the latest, but it has a good set of improvements over 1.2. It's already still pretty old, but it's the latest version that can run inside binder / jupyterhub for not - until jupyterhub/jupyter-rsession-proxy#93 (comment) is dealt with. - Just install jupyter-rsession-proxy from PyPI, it brings in the appropriate verison of jupyter-server-proxy - Explicit server extension or client extension enable is not necessary
yuvipanda
force-pushed
the
bump-rstudio
branch
from
013125a
to
7ee40c6
Compare
|
A couple of related issues:
Does this PR have any bearing on those issues, either fixing them or adding another test case? |
|
@manics doesn't affect either. #1041 will require an even newer version of rstudio, which jupyter-rsession-proxy (which would be fixed by jupyterhub/jupyter-rsession-proxy#107). #1077 is unrelated but I think I know what's up with that. |
repo2docker/buildpacks/_r_base.py
Outdated
| jupyter nbextension install --py jupyter_server_proxy --sys-prefix && \ | ||
| jupyter nbextension enable --py jupyter_server_proxy --sys-prefix | ||
| pip install --no-cache-dir jupyter-rsession-proxy==1.4 && \ | ||
| pip install --no-cache-dir https://github.com/ryanlovett/jupyter-shiny-proxy/archive/47557dc47e2aeeab490eb5f3eeae414cdde4a6a9.zip |
There was a problem hiding this comment.
Is this ready to merge, or do you want to wait for a release?
There was a problem hiding this comment.
I think this is ready to merge now - I just haven't touched the shiny-proxy setup for now.
There was a problem hiding this comment.
Hmm actually - maybe let's wait a few days, and see if we can get up to a much more modern rstudio.
There was a problem hiding this comment.
@manics ok I've upgraded this now to use latest rstudio and jupyter-rsession-proxy.
jupyter-rsession-proxy 2.x now supports latest RStudio, so we can upgrade them both!
yuvipanda
force-pushed
the
bump-rstudio
branch
from
b14adca
to
8fac75f
Compare
Otherwise bash interpretes the > as a redirect
|
Looks like RStudio version needs to depend on the version of R we have in the image... |
|
Looks like latest RStudio doesn't support R < 4.1 :( I'm opening #1102 instead first, supporting 4.1. We'll have to install different versions of RStudio for different versions of R |
|
Closing in favor of #1104 |
versions of jupyter-rsession-proxy were not compatible with newer versions of
RStudio
appropriate verison of jupyter-server-proxy