-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning R 4.0 with runtime.txt on mybinder.org not working as expected #1077
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Hi, unfortunately using Overall our support for R is a bit basic. This has a few reasons, but the most important one is that we lack people who really use and know R. It would be great to find someone who has more experience in that area and wants to help out. If I recall correctly the |
I get the same problem as reported above. Another issue with the R 4.0.2 support (or 4.1.0) is that Rstudio is too old (from 2019) compared to R 4.1.0 and so plots are not visible. For an example, see: https://github.com/sje30/rescience-hor and hit the binder button. (it takes a few mins to spin up) after running
CC: @nuest |
@betatim Hi, My guess is that the step |
I've transferred this issue to the repo2docker repo which is the tool that handles the builds behind BinderHub. This is an excerpt of the internal generated ...
COPY --chown=1000:1000 src/environment.yml ${REPO_DIR}/environment.yml
USER ${NB_USER}
RUN TIMEFORMAT='time: %3R' \
bash -c 'time mamba env update -p ${NB_PYTHON_PREFIX} -f "environment.yml" && \
time mamba clean --all -f -y && \
mamba list -p ${NB_PYTHON_PREFIX} \
'
RUN mamba install -p ${NB_PYTHON_PREFIX} r-base r-irkernel=1.1 r-devtools -y && \
mamba clean --all -f -y && \
mamba list -p ${NB_PYTHON_PREFIX}
...
repo2docker/repo2docker/buildpacks/_r_base.py Lines 19 to 20 in 6e2a6af
repo2docker/repo2docker/buildpacks/conda/__init__.py Lines 347 to 353 in 6e2a6af
|
A first step can be to improve the tests: to check also the minor version and add more tests. To check the minor version, e.g. ! startsWith(paste(version$major,version$minor,sep="."),"4.0") Is this something that would add value and that I can suggest in a pull request? |
@aplamada More tests are always welcome! I think a long term fix for this bug may require one of:
I'm not sure what's best though. |
@manics Thanks for your feedback! Also it is not very clear to me why R with install.R is not following Python with requirements.txt . So either install.R can happen always in the conda env of R, or Python can be installed with |
This issue has been mentioned on Jupyter Community Forum. There might be relevant details there: |
@yuvipanda This is great news! |
Unfortunately, the repository does not build at all anymore: Build logs
Maybe related: #1116 |
It works now, maybe because of #1114. Not sure though. |
Bug description
Pinning the R version to 4.0 using
runtime.txt
onmybinder.org
does not work – I get R 4.1 instead.Expected behaviour
I expect R version 4.0.5 ("Shake and Throw"):
Actual behaviour
I get R version 4.1.0 ("Camp Pontanezen"):
How to reproduce
runtime.txt
:Your personal set up
I am using the
mybinder.org
service.Versions:
jupyterhub --version
:1.3.0
python --version
:Python 3.7.10
Full environment
Related information
Explicitly demanding R 4.1 using the following
runtime.txt
……does not work (which makes sense):
Try here:![Binder](https://camo.githubusercontent.com/4e66027072f7aa2f6b53bb56e496d94879d3d8c3160145d6db1b1edb55096bd2/68747470733a2f2f6d7962696e6465722e6f72672f62616467652e737667)
The text was updated successfully, but these errors were encountered: