Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia 1.5.0 support #938

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Add Julia 1.5.0 support #938

merged 1 commit into from
Aug 14, 2020

Conversation

tomyun
Copy link
Contributor

@tomyun tomyun commented Aug 4, 2020

Julia 1.5.0 just released yesterday. Hopefully this works for Binder.

@betatim
Copy link
Member

betatim commented Aug 13, 2020

Our tests fail because packages like IJulia don't precompile. Not sure if this is expected or not when we upgrade Julia version.

Do you know more about what changed between 1.5 and the previous version?

@betatim
Copy link
Member

betatim commented Aug 13, 2020

Actually, it is the Julia legacy test (tests/julia/julialegacy_version-1.1) for v1.1. which has started failing.

@davidanthoff any ideas what recently happened in Julia world that this would stop working?

Actually, actually it seems most of the "legacy" test cases suddenly fail https://dev.azure.com/jupyter/repo2docker/_build/results?buildId=305&view=logs&j=ee64945a-faa3-5012-a8b2-5da449b6aeed&t=800caa60-10d1-50ab-ca6c-028744e4732a&l=33 takes you to a overview of the tests that pass/fail.

@davidanthoff
Copy link
Contributor

Hm, good question... Maybe the Julia definition in the REQUIRE file is read as a semver version, so writing julia 1.1 in REQUIRE means "any version that is compatible with 1.1", and that of course would include 1.5. BUT, I think 1.5 might have removed support for REQUIRE files...

If that is so, we should just cap the Julia version one can get via a REQUIRE file to Julia 1.4.2. The whole REQUIRE stuff is completely legacy in any case.

@betatim
Copy link
Member

betatim commented Aug 14, 2020

Modified the julia buildpack locally to print out the version with julia --version. Three observations: it prints 1.0.2 for the 1.0.2 test (👍), it uses the buildpack for Project.toml based projects, and it runs to completion. So maybe this was a glitch because ... glitches happen?

Restarted the CI jobs.

@betatim betatim closed this Aug 14, 2020
@betatim betatim reopened this Aug 14, 2020
@betatim betatim merged commit 82eb2b1 into jupyterhub:master Aug 14, 2020
@welcome
Copy link

welcome bot commented Aug 14, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants