Adds Python 3.9 compatability by fixing asyncio api changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.7 deprecated "with await lock" (https://docs.python.org/3.7/library/asyncio-sync.html#boundedsemaphore) Python 3.7 deprecated "asyncio.Tasks.all_tasks" This changes to the new API while maintaining 3.6 support.
tdhopper
force-pushed
the
python3.9-support
branch
from
8b5a890
to
ba7f52a
Compare
|
Hmm, once in a while on 3.9, I'm getting a SIGKILL instead of a SIGTERM in the |
|
Thanks a lot for opening this, @tdhopper! I've also invited you as a collaborator on this repo :) |
|
How often are you getting the SIGKILL? Could that be just a change in timing / race condition? |
|
@yuvipanda Race condition seems likely. I re-ran the test 100 times and it didn't happen again 🤷♂️ |
|
Thanks, @tdhopper :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 deprecated
with await locksyntaxPython 3.7 deprecated "asyncio.Tasks.all_tasks" and added
asyncio.all_tasksThis changes to the new API while maintaining 3.6 support.
Relates to ideonate/jhsingle-native-proxy#8