Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Centos 7 #53

Merged
merged 2 commits into from
Jun 12, 2019
Merged

fix for Centos 7 #53

merged 2 commits into from
Jun 12, 2019

Conversation

mortbauer
Copy link
Contributor

I have seen #9 but from my testing I only managed to make it work if I completely remove that line.

@dmpe
Copy link

dmpe commented Jun 10, 2019

@yuvipanda

@hansen-m
Copy link

I can confirm this is still an issue with 219.

@yuvipanda
Copy link
Collaborator

Thanks for the PR, @mortbauer. Instead of commenting out the line, if you just remove it I'm happy to merge it.

@yuvipanda yuvipanda merged commit 4c3d517 into jupyterhub:master Jun 12, 2019
@yuvipanda
Copy link
Collaborator

Thanks, @mortbauer!

This was referenced Nov 12, 2019
@subgero
Copy link

subgero commented Mar 19, 2020

@mortbauer Could you please tell us, What line are you talking about?

@mortbauer
Copy link
Contributor Author

@subgero please just have a look at the pull request, it removes one line

@adamboutcher
Copy link

Can confirm removing this line fixed spwaning for me on CentOS 7.8

@yuvipanda
Copy link
Collaborator

I released 0.14 with this fix a week ago.

@adamboutcher
Copy link

Well it hasn't hit upstream into tljh yet then because I had to edit that line yesterday.

yuvipanda added a commit to jupyterhub/the-littlest-jupyterhub that referenced this pull request Jul 29, 2020
@yuvipanda
Copy link
Collaborator

@adamboutcher I've bumped it in jupyterhub/the-littlest-jupyterhub#602.

Does TLJH run on Centos? I thought we bailed early if it isn't ubuntu...

@adamboutcher
Copy link

It does bail but its only an issue because they hard code apt, removing any apt lines, manually installing the deps and removing the Ubuntu check and it magically works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants