Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling in bootstrap script #16

Closed
yuvipanda opened this issue Jul 2, 2018 · 6 comments
Closed

Better error handling in bootstrap script #16

yuvipanda opened this issue Jul 2, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@yuvipanda
Copy link
Collaborator

Provide nicer error messages, and check for error conditions properly in the bootstrap script.

@yuvipanda
Copy link
Collaborator Author

Things to check:

  1. Ubuntu
  2. Appropriate version of Ubuntu
  3. Git installed
  4. Appropriate version of Python
  5. Systemd installed and present (accounts for running inside docker container)

@yuvipanda
Copy link
Collaborator Author

From #219 (comment), we should also check for external internet access & fail if we can't reach it. (Thanks @fm75)

@yuvipanda
Copy link
Collaborator Author

We already do the following:

  1. Validate it's ubuntu
  2. Validate version of ubuntu
  3. We install git ourselves, so that's ok

yuvipanda added a commit to yuvipanda/the-littlest-jupyterhub that referenced this issue May 20, 2019
- Check for Python Version
- Check if systemd is present
- Provide more useful error message when running inside
  an unprepared docker container

Ref jupyterhub#16
@yuvipanda
Copy link
Collaborator Author

I'm not particularly sure how to check for 'do we have internet access'. I don't want to do something like 'ping google.com' or any particular external website, since that will leak information about the server being installed. I guess we should watch for apt failures and suggest that as a possible solution.

@yuvipanda
Copy link
Collaborator Author

#340 adds validation for python version and systemd presence. It also handles erroring with a more useful error message when running inside docker.

@consideRatio
Copy link
Member

I'll close this, we don't check explicitly for internet connection issues, but we covered all the rest listed here:

  • Ubuntu
  • Appropriate version of Ubuntu
  • Git installed
  • Appropriate version of Python
  • Systemd installed and present (accounts for running inside docker container)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants