Add more validation to bootstrap.py #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for Python Version - Check if systemd is present - Provide more useful error message when running inside an unprepared docker container Ref jupyterhub#16
|
Docs on docker container in #333. This still needs tests though. |
|
Test added. I'm curious about the wording. I'm not sure 'plain' docker container is quite right. |
|
Not quite sure what it means to run in "plain docker". It makes me think that this is using a version of docker that hasn't been modified. As in the "plain" refers to dockerd, not the image that we are using (which is what I think this is about). Could it be named "no-systemd-docker"? |
'Plain docker' makes no sense
|
@betatim updated to refer to 'docker container without systemd' instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an unprepared docker container
Ref #16