Don't create home publicly readable #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
World-Readable seem to be a surprising default for many people, especially in teaching context. Switch to a more reasonable rwxr-x--- We have to issue a chmod, as changing at creation time would require changin /etc/adduser.conf DIR_MODE=0760 (or whatever), but that seem unwise. We do not set the exact permission in case the DIR_MODE is more restrictive. Closing jupyterhub#158
Carreau
force-pushed
the
no-everyone-read
branch
from
e08652e
to
552db9f
Compare
|
I don't think it needs config. Do you want to add a test to verify that a user's dir isn't world-readable? |
Carreau
force-pushed
the
no-everyone-read
branch
from
70ad25e
to
109703d
Compare
Carreau
force-pushed
the
no-everyone-read
branch
from
109703d
to
5bbba2b
Compare
I should right ? I've added tests, let's see if they pass. |
|
Circle is happy ! |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
World-Readable seem to be a surprising default for many people,
especially in teaching context. Switch to a more reasonable
rwxr-x---We have to issue a chmod, as changing at creation time would require
changin /etc/adduser.conf DIR_MODE=0760 (or whatever), but that seem
unwise.
We do not set the exact permission in case the DIR_MODE is more
restrictive.
Closing #158
(cc @mstobb)
One question is do we want that to be configurable ? I tend to think no.