Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check/change default umask #158

Closed
Carreau opened this issue Aug 28, 2018 · 1 comment
Closed

check/change default umask #158

Carreau opened this issue Aug 28, 2018 · 1 comment

Comments

@Carreau
Copy link
Member

Carreau commented Aug 28, 2018

While walking in central valley today I came across a wild jupyterhub running in a grass field. It was used to teach R. Admins were surprised that students could see each other files.

Would it make sens to me to change the umask to 025 (I believe), use the -M 750 of adduser when possible (not available on Ubuntu AFAICT), or at least subprocess.check_call(['chmod','0750', f'~{user}']).

It seem to be a reasonable default IMHO
Carreau added a commit to Carreau/the-littlest-jupyterhub that referenced this issue Aug 29, 2018
@Carreau
Don't create home publicly readable
511a063 
World-Readable seem to be a surprising default for many people,
especially in teaching context. Switch to a more reasonable rwxr-x---

We have to issue a chmod, as changing at creation time would require
changin /etc/adduser.conf DIR_MODE=0760 (or whatever), but that seem
unwise.

We do not set the exact permission in case the DIR_MODE is more
restrictive.

Closing jupyterhub#158
Carreau added a commit to Carreau/the-littlest-jupyterhub that referenced this issue Aug 29, 2018
@Carreau
Don't create home publicly readable
e08652e 
World-Readable seem to be a surprising default for many people,
especially in teaching context. Switch to a more reasonable rwxr-x---

We have to issue a chmod, as changing at creation time would require
changin /etc/adduser.conf DIR_MODE=0760 (or whatever), but that seem
unwise.

We do not set the exact permission in case the DIR_MODE is more
restrictive.

Closing jupyterhub#158
@Carreau Carreau mentioned this issue Aug 29, 2018
Merged
2 tasks
Carreau added a commit to Carreau/the-littlest-jupyterhub that referenced this issue Aug 29, 2018
@Carreau
Don't create home publicly readable
552db9f 
World-Readable seem to be a surprising default for many people,
especially in teaching context. Switch to a more reasonable rwxr-x---

We have to issue a chmod, as changing at creation time would require
changin /etc/adduser.conf DIR_MODE=0760 (or whatever), but that seem
unwise.

We do not set the exact permission in case the DIR_MODE is more
restrictive.

Closing jupyterhub#158
@yuvipanda
Copy link
Collaborator

This was fixed in #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @Carreau