Few updates from reading through the docs #325
Conversation
|
@yuvipanda and team thanks for all your efforts on this again! I'm just spinning up my own server and will add any typos I find in here, hopefully that's useful. One other thing. I don't know if it's useful but I somehow managed to break my server yesterday, but it now works after re-building the machine - would it be worth adding a 'Have you tried re-booting from scratch?' reminder to the troubleshooting page of custom servers? |
|
This is awesome, @znicholls! Thank you for making the effort to make the PR. Your contributions are very useful, and hopefully we'll see more :) This PR is still marked as draft, so am happy for you to add more to this or mark it as ready - it's in a mergeable state now. Re: re-booting from scratch, did you just reboot the machine or delete things and start over? Might be worth opening a separate issue to discuss that. Welcome to the TLJH github! |
I'll add more as I keep reading and then mark it ready later. |
#338 :) |
There was a problem hiding this comment.
I think the comment about restarting/deleting the server was a big vague.
Does it mean something to restart jupyterhub and traefik, the entire machine. And respectively, does delete mean to reset the entire machine, or to do an uninstallation of TLJH - which I recall to not be documented in such a clear way.
The other changes look great to me without a doubt!
|
It means either a restart or simply deleting the server entirely and spinning up a new virtual machine. I don't think it's possible to easily uninstall tljh (or it wasn't when I made this PR) |
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks @znicholls and @minrk for the followup adjustment! |
Closes #338