Make bootstrap_pip_spec test argument optional #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgianaElena
changed the title
2 tasks
jtpio
reviewed
Apr 30, 2020
| @@ -158,8 +158,8 @@ def main(): | |||
| run_test_parser = subparsers.add_parser('run-test') | |||
| run_test_parser.add_argument('--installer-args', default='') | |||
| run_test_parser.add_argument('--upgrade', action='store_true') | |||
| run_test_parser.add_argument('--bootstrap_pip_spec', nargs='?', default="", type=str) | |||
There was a problem hiding this comment.
Wondering whether the parameter should be named --bootstrap-pip-spec, similar to --installer-args? (so they both follow the same style)
There was a problem hiding this comment.
Oh, right 😕 Yes, that would be better.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
bootstrap_pip_specan optional argument so that when running the integration tests locally, users won't need to add the empty string as an arg (for the default tljh bootsrap pip spec) or the entire pip spec.-
[ ] Add / update documentation-
[ ] Add tests