Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to --bootstrap-pip-spec in the integration tests #566

Merged
merged 1 commit into from May 4, 2020
Merged

Rename to --bootstrap-pip-spec in the integration tests #566

merged 1 commit into from May 4, 2020

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented May 4, 2020

Quick follow-up for #558 and #563, to keep the style consistent with other parameters such as --installer-args.

  • Add / update documentation
  • Update tests

GeorgianaElena
GeorgianaElena approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jtpio 🎉

@GeorgianaElena GeorgianaElena merged commit 8d2a1c8 into jupyterhub:master May 4, 2020
@jtpio jtpio deleted the integration-pip-spec branch May 4, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @GeorgianaElena