Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove addressed FIXMEs in update_auth #745

Merged
merged 1 commit into from Oct 27, 2021
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 27, 2021

These are both addressed by the use of traitlets.config:

  • an informative error is raised if the auth class cannot be imported
  • only configurable traits on Configurable classes can be set this way, not any attribute on any object

A check for importability of the auth config class is appropriate, but not here, during the loading of config, where there is already a check when JupyterHub attempts to load the auth class. It would be appropriate during tljh-config which sets the config, however.

also fix a couple of typos in the docstring that I introduced during review of #721

Closes #740 (edit by Erik)

These are both addressed by the use of traitlets.config

- an informative error is raised if the auth class cannot be imported
- only configurable traits can be set, not any attribute on any object

also fix a couple of typos in the docstring that I introduced during review
@yuvipanda yuvipanda merged commit bbd358f into jupyterhub:main Oct 27, 2021
@yuvipanda
Copy link
Collaborator

Thanks a lot for bearing with me, @minrk and @consideRatio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify and/or resolve FIXME notes in configurer.py
3 participants