Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove addressed FIXMEs in update_auth #745

Merged
merged 1 commit into from
Oct 27, 2021
Merged

remove addressed FIXMEs in update_auth #745

merged 1 commit into from
Oct 27, 2021

Commits on Oct 27, 2021

  1. remove addressed FIXMEs in update_auth 

    These are both addressed by the use of traitlets.config

- an informative error is raised if the auth class cannot be imported
- only configurable traits can be set, not any attribute on any object

also fix a couple of typos in the docstring that I introduced during review
    @minrk
    minrk committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    d3412a1 View commit details
    Browse the repository at this point in the history