pre-commit: apply black formatting (and prettier on one yaml file) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/apply-black
branch
4 times, most recently
from
cc61607
to
b0f345f
Compare
consideRatio
force-pushed
the
pr/apply-black
branch
from
b0f345f
to
1120466
Compare
consideRatio
changed the title
40 tasks
|
@manics @yuvipanda @choldgraf what do you think? The PR list is down from 20 to 1 single stale PR with very little changes, can we go for a full Waiting for this to get merged is somewhat of a blocker to start doing more work as well.
|
choldgraf
approved these changes
Nov 4, 2021
|
Thanks @manics @choldgraf! I'll go for a merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've applied black formatting now. I ran it once first without string normalization, applied some manual tweaks, and then ran it with string normalization.
String normalization isn't systematically used with black in the jupyterhub org. I personally favor it though and figure it could make sense to do while also applying black in the first place - something that is reasonable to do only when the amount of PRs are low.