Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added remove_named_servers setting for jupyterhub-idle-culler #855

Closed
wants to merge 3 commits into from

Conversation

stevejpurves
Copy link
Contributor

@stevejpurves stevejpurves commented Mar 20, 2023

If you are using TLJH with named servers, it can be a requirement that the server is removed when culled. This PR is to expose the underlying IdleCuller option, allowing it to be set via tljh-config.

  • Add / update documentation
  • Add tests

@welcome
Copy link

welcome bot commented Mar 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@stevejpurves
Copy link
Contributor Author

I noted some issues with the test suite while getting this to go green. It seems like he mock config can leak between tests meaning it was not possible to add a test for remove_named_servers independently of users.

Also I added a test case where potentially the existing test case for services could be extended instead -- let me know if I should change that.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has merge conflicts that needs to be manually resolved, but this LGTM and can be merged when those are resolved!

Thank you @stevejpurves for your work on this!!! ❤️ 🎉 🌻

@consideRatio consideRatio changed the title added remove_named_servers setting added remove_named_servers setting for the jupyterhub-idle-culler Apr 9, 2023
@consideRatio consideRatio changed the title added remove_named_servers setting for the jupyterhub-idle-culler added remove_named_servers setting for jupyterhub-idle-culler Apr 9, 2023
@consideRatio consideRatio added the enhancement New feature or request label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants