added remove_named_servers setting for jupyterhub-idle-culler
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
Apr 24, 2023
| @@ -40,6 +40,12 @@ the users will not be culled alongside their notebooks and will continue to exis | |||
| services.cull.users = False | |||
| ``` | |||
|
|
|||
| If named servers are in use, they are not removed after being culled. | |||
There was a problem hiding this comment.
I make one edit during the rebase here.
Previously it said If named servers are in use, remove the server after stopping it. which didn't make sense to describe the default value of False for remove_named_servers.
|
Hey @stevejpurves, this is based on your PR in #855, but also manually handling merge conflicts from having merged #863. If its alright with you, I'll go for a merge here! |
|
I'm going for a merge, hoping its okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #855 by @stevejpurves that has been manually rebased to handle conflicts following from rST to MyST. I had to open a new PR to resolve this as I wasn't allowed to push to #855
@stevejpurves is this okay with you to merge? I made one edit besides the rST -> MyST markdown conversions required to solve merge conflicts from #863. You can see that change in a comment below.
Closes #855.
Original PR
If you are using TLJH with named servers, it can be a requirement that the server is removed when culled. This PR is to expose the underlying IdleCuller option, allowing it to be set via
tljh-config.