-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only upgrade jupyterhub in user env when upgrading tljh, ensure pip>=23.1.2 in user env #890
Only upgrade jupyterhub in user env when upgrading tljh, ensure pip>=23.1.2 in user env #890
Conversation
From live meeting chat with input from Min and Simon
EDIT: I did |
27323ab
to
36a78ca
Compare
b5a9215
to
5683e52
Compare
9727e3a
to
21312b2
Compare
@minrk @manics modified the git history of this PR to make it a bit more slimmed and easy to follow after trying some things and going back on them. I've updated the title and PR description to reflect this. Note that it was messy to inspect the hub env as we install the hub env after user env, and that we have unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me. I don't love parsing the jupyterhub requirement with such a strict pattern, but I understand it.
If we impose restrictions on e.g. jupyter-server
version in the user env, I'm not sure where that would go.
Additional changes