Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recently introduced failure to upper bound systemdspawner #914

Merged
merged 1 commit into from Jun 5, 2023
Merged

Fix recently introduced failure to upper bound systemdspawner #914

merged 1 commit into from Jun 5, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jun 5, 2023 •
edited

I made a typo in #890, is that what has caused the tests to start failing? Yes!!!

@consideRatio consideRatio added the bug Something isn't working label Jun 5, 2023
@consideRatio consideRatio merged commit 93515a8 into jupyterhub:main Jun 5, 2023
12 checks passed
@minrk
Copy link
Member

minrk commented Jun 6, 2023

So this means systemdspawner 1 is what broke it?

@consideRatio
Copy link
Member Author

Yes :/

@consideRatio consideRatio self-assigned this Jun 6, 2023
@consideRatio consideRatio added maintenance and removed bug Something isn't working labels Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@consideRatio consideRatio

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests broken without change last week
2 participants
@consideRatio @minrk