Clean up a line in the CI logs #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value was previously quoted with ", but when chartpress parses this YAML and writes it back, the following change arise: - hstsIncludeSubdomains: "false" + hstsIncludeSubdomains: 'false' So, by either making this value a boolean or a string with single quote we get rid of this log entry coming from a `git diff`. I went with single quotes for a minimalistic change.
|
ty, @consideRatio! It needs to be a quoted value rather than a boolean, since configmap values must be strings. |
|
@yuvipanda ah but I think since the configmap in question adds them it would had worked with boolean values as well, but I like this as it is made clear that this will per parsed as a string in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value was previously quoted with ", but when
chartpressparses thisYAML and writes it back in our CI steps, the following change arise and is
written to the logs which distracted me.
So, by either making this value a boolean or a string with single quote
we get rid of this log entry coming from a
git diff. I went withsingle quotes for a minimalistic change.