Add py-spy to hub image #1327
Merged
Add py-spy to hub image #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/benfred/py-spy is a sampling profiler for Python that works really solidly with minimum fuss, and has been extremely helpful in debugging issues. It's also very useful in doing performance analysis. Having this be present in the hub image by default will make it easier for everyone to create profiles of the hub process at loads they are having trouble with, and share it with the community to see what is up.
|
Nice! |
|
Cool tool! I'll find use for this now as well! ( The CI Pipeline for the PR failed, related to this being a in-repo-branch-pr, but the actual pipeline triggered on the merge to master ran as it should, so there should be a new helm chart release with this image bumped still ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/benfred/py-spy is a sampling profiler for Python
that works really solidly with minimum fuss, and has been extremely
helpful in debugging issues. It's also very useful in doing performance
analysis. Having this be present in the hub image by default will
make it easier for everyone to create profiles of the hub process
at loads they are having trouble with, and share it with the community
to see what is up.