Skip to content

Add py-spy to hub image#1327

Merged
minrk merged 1 commit intomasterfrom
yuvipanda-patch-1
Jul 11, 2019
Merged

Add py-spy to hub image#1327
minrk merged 1 commit intomasterfrom
yuvipanda-patch-1

Conversation

@yuvipanda
Copy link
Collaborator

https://github.com/benfred/py-spy is a sampling profiler for Python
that works really solidly with minimum fuss, and has been extremely
helpful in debugging issues. It's also very useful in doing performance
analysis. Having this be present in the hub image by default will
make it easier for everyone to create profiles of the hub process
at loads they are having trouble with, and share it with the community
to see what is up.

https://github.com/benfred/py-spy is a sampling profiler for Python
that works really solidly with minimum fuss, and has been extremely
helpful in debugging issues. It's also very useful in doing performance
analysis. Having this be present in the hub image by default will
make it easier for everyone to create profiles of the hub process
at loads they are having trouble with, and share it with the community
to see what is up.
@minrk minrk merged commit 733d771 into master Jul 11, 2019
@minrk
Copy link
Member

minrk commented Jul 11, 2019

Nice!

@consideRatio
Copy link
Member

consideRatio commented Jul 11, 2019

Cool tool! I'll find use for this now as well!

( The CI Pipeline for the PR failed, related to this being a in-repo-branch-pr, but the actual pipeline triggered on the merge to master ran as it should, so there should be a new helm chart release with this image bumped still )

@yuvipanda yuvipanda deleted the yuvipanda-patch-1 branch November 6, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants