-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made compute zone name generic #1431
Conversation
@consideRatio here's the PR. Thanks! |
@consideRatio any idea why it's not passing the Travis CI check? |
@willingc made the changes you suggested! Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for slow feedback about this PR! If we introduce the concept of regional clusters, I'd like to see some additional understanding presented as well.
- If you create a regional cluster, you will by default create nodes in at least three zones.
- If you create a regional cluster, you will always get High Availability (HA) on your k8s api-server for free. This means that
kubectl get pods
for example should keep working no matter if an individual api-server is being upgraded which they automatically are sometimes. - If you want to reap the benefit of a HA k8s api-server while not tripling the amount of nodes, you can limit your own servers to one single zone by using the
--node-locations
flag and specifying a specific zone, such asus-central1-a
:
@consideRatio thanks for the review! |
@consideRatio sorry for the delay! |
@willingc @consideRatio would love it if you could review this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this ❤️! I made some suggestions, if they look good to you it all LGTM!
Co-Authored-By: Erik Sundell <erik.i.sundell@gmail.com>
@consideRatio the changes look good. Added the changes with a couple of minor fixes. |
Thank you for this thorough work @metonymic-smokey! ❤️ 🎉 |
Refers to issue #1296
Changed file to make compute zone reference generic and added a note about regional clusters.