Complexity reduction - combine passthrough values.yaml data in hub-config (k8s configmap) to hub-secret (k8s secret) #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Aug 25, 2020
JupyterHub itself, authenticators, etc, all may want to use the values
we also use to render the Helm charts templates. So, we typically take
them av available in {{ .Values }}, split it apart, and render it to a
k8s configmap as well as a k8s secret.
This separation had little to no benefit and was hard to maintain. In
this commit I gather the {{ .Values }} into the hub-secret file. I also
configure c.JupyterHub.cookie_secret instead of passing that
information by mounting a k8s secrets key's value into a
JPY_COOKIE_SECRET environment variable on the hub pod.
Co-Authored-By: Min RK <benjaminrk@gmail.com>
consideRatio
force-pushed
the
all-configmap-passthrough-in-secret
branch
from
e21d214
to
9aff240
Compare
15 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JupyterHub itself, authenticators, etc, all may want to use the values
we also use to render the Helm charts templates. So, we typically take
them av available in {{ .Values }}, split it apart, and render it to a
k8s configmap as well as a k8s secret.
This separation had little to no benefit and was hard to maintain. In
this commit I gather the {{ .Values }} into the hub-secret file. I also
configure c.JupyterHub.cookie_secret instead of passing that
information by mounting a k8s secrets key's value into a
JPY_COOKIE_SECRET environment variable on the hub pod.