-
Notifications
You must be signed in to change notification settings - Fork 830
Docs: assume usage of helm3 over deprecated helm2 #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c48093 to
046b07c
Compare
|
FWIW we recently upgraded our testing environment hub from helm2 to helm3 and one of the things we needed to do was set |
manics
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions after a first pass over the docs.
|
@GeorgianaElena thank you for working on this and thanks @manics for the review! ❤️ For instructors on how to migrate from Helm2 -> Helm3, I think we should save ourselves some work by referencing the official docs straight up even though I suggested otherwise before. They are complicated to follow, but I don't think we should spend time trying to simplify them. |
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
|
Thanks for reviewing this @manics and @consideRatio ❤️ |
|
Wieee! Thanks for your work on this @GeorgianaElena! I'll go ahead and merge even though there is an error in CI because i know it is transient and fixed in current master. |
To do list (based on @consideRatio's summary here ✨ ):
--purge--timeoutspec--cleaup-on-failalways when upgradingtiller