Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: assume usage of helm3 over deprecated helm2 #1684

Merged
merged 10 commits into from
Sep 4, 2020

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented May 28, 2020

To do list (based on @consideRatio's summary here ✨ ):

  • no need to --purge
  • new --timeout spec
  • --cleaup-on-fail always when upgrading
  • no tiller
  • make it clear that the docs assume helm3
  • instructions on how to migrate from helm2 to helm3 for an existing cluster
  • remove section about helm2 setup (or keep it for compatibility)

@consideRatio consideRatio self-requested a review May 28, 2020 10:03
@mriedem
Copy link
Contributor

mriedem commented Sep 4, 2020

FWIW we recently upgraded our testing environment hub from helm2 to helm3 and one of the things we needed to do was set c.JupyterHub.hub_connect_ip = 'hub' so that notebooks hit the hub API URL by hostname rather than service IP (which changed with our upgrade to helm3).

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions after a first pass over the docs.

doc/source/setup-jupyterhub/setup-helm.rst Outdated Show resolved Hide resolved
doc/source/setup-jupyterhub/setup-helm.rst Outdated Show resolved Hide resolved
doc/source/setup-jupyterhub/setup-helm.rst Outdated Show resolved Hide resolved
doc/source/setup-jupyterhub/setup-helm.rst Outdated Show resolved Hide resolved
doc/source/setup-jupyterhub/setup-jupyterhub.rst Outdated Show resolved Hide resolved
@consideRatio
Copy link
Member

@GeorgianaElena thank you for working on this and thanks @manics for the review! ❤️

For instructors on how to migrate from Helm2 -> Helm3, I think we should save ourselves some work by referencing the official docs straight up even though I suggested otherwise before. They are complicated to follow, but I don't think we should spend time trying to simplify them.

@GeorgianaElena
Copy link
Member Author

Thanks for reviewing this @manics and @consideRatio ❤️

@consideRatio
Copy link
Member

Wieee! Thanks for your work on this @GeorgianaElena!

I'll go ahead and merge even though there is an error in CI because i know it is transient and fixed in current master.

@consideRatio consideRatio merged commit b92c0a5 into jupyterhub:master Sep 4, 2020
@consideRatio consideRatio changed the title [WIP] Make the docs assume helm3 Docs: assume usage of helm3 over deprecated helm2 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants