Relax hook-image-puller to make upgrades more reliable #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration makes the hook-image-awaiter start comparing the number of scheduled image-puller pods with the number of ready image-puller pods, instead of comparing the number of desired image-puller pods with the ready number of image-puller pods, after a duration of 10 seconds. This helps anyone using the hook-image-puller to avoid failures of running `helm upgrade` that can happen if a node is full packed with pods and no more pods can be scheduled on it, because then the image-awaiter would get stuck waiting forever on an image pulling pod that never successfully schedules to do the actual pulling.
|
Awesome! I'll deploy current master in a day or so and we'll give it a couple weeks? |
|
@yuvipanda deal, thanks! I love that you are an active user of the master branch, it really helps the development of a project to have those that use the tip of the master branch. |
|
@yuvipanda OK to merge merge this prior to releasing 0.10.0-beta.1? |
|
Thanks for waiting, @consideRatio! |
|
@yuvipanda and @GeorgianaElena thank you for your review work on this feature! ❤️ |
yuvipanda
added a commit
to yuvipanda/datahub-old-fork
that referenced
this pull request
Oct 5, 2020
Mostly to bring in jupyterhub/zero-to-jupyterhub-k8s#1787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration makes the hook-image-awaiter start comparing the
number of scheduled image-puller pods with the number of ready
image-puller pods, instead of comparing the number of desired
image-puller pods with the ready number of image-puller pods, after a
duration of 10 seconds.
This helps anyone using the hook-image-puller to avoid failures
of running
helm upgradethat can happen if a node is full packed withpods and no more pods can be scheduled on it, because then the
image-awaiter would get stuck waiting forever on an image pulling pod
that never successfully schedules to do the actual pulling.
@yuvipanda I merged #1763 and created this as a followup to the review comment #1763 (comment) about sticking with the existing behavior until its been tested a while.