Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy version in DigitalOcean Kubernetes setup doc #1788

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Fix legacy version in DigitalOcean Kubernetes setup doc #1788

merged 1 commit into from
Sep 26, 2020

Conversation

subwaymatch
Copy link
Contributor

In the Kubernetes on Digital Ocean doc page, there are two minor issues.

image

The doctl k8s cluster create command is using an outdated Kubernetes version. Using 1.12.1-do.2 throws a 422 validation error.

image
image

When creating a Kubernetes cluster through Digital Ocean's dashboard, only versions 1.16.14 and up seem to be supported.
image

I've replaced the legacy version with latest 1.18.8-do.0.


The doctl k8s cluster create command is also missing a double quote at the end. I've added the missing double quote.

Confirmed by testing in Ubuntu 20.04:
image

@welcome
Copy link

welcome bot commented Sep 26, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us keep the docs up to date 😀

@manics manics merged commit 2f8fa98 into jupyterhub:master Sep 26, 2020
@welcome
Copy link

welcome bot commented Sep 26, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants