Added rediraffe redirecgtion #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added commas missed fixed rediraffe redirects Removed a typo. That's it. Removed a typo. That's it. Removed a typo. That's it. Removed a typo. That's it. commented broken links
NerdSec
force-pushed
the
manage-redirects-plugin
branch
from
7c9da24
to
1358797
Compare
consideRatio
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
I tried this locally, and it works nice! I pushed a commit to make make devenv still work again after the refactoring.
I only wonder about the commented out redirects, why are they made? Ah they were an older redirect to a file that was moved in this recent refactoring. I updated them to reference directly to the new location.
@choldgraf I have now removed all old RTD based redirects and with this PR we are now rediraffing amazingly! :D
Thank you a lot @NerdSec for your work on this! ❤️ 🎉
|
wohoo! can we all also appreciate how great the rediraffe logo is?
|
|
Haha yes :D 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1865, added the ability to perform redirects outside of RTD by leveraging rediraffe.