Enable hub livenessProbe by default and relax hub/proxy probes #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action-k3s-helm was moved to jupyterhub
manics
reviewed
Dec 12, 2020
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 12, 2020
jupyterhub/zero-to-jupyterhub-k8s#1941 Merge pull request #1941 from consideRatio/pr/tweak-liveness-readiness-probes-settings-to-be-less-strict
|
Wieee thanks for your help @manics! |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/jupyterhub-helm-chart-0-11-0-released/7521/1 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1936 and stems from a deliberations in #1732 that I suggest we close when we have added a startupProbe as suggested in an action point in #1732 (comment).
The actual changes are: