Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: stop using --long as chartpress 1.0.0 makes it not needed #2018

Merged
merged 1 commit into from Jan 28, 2021
Merged

ci: stop using --long as chartpress 1.0.0 makes it not needed #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions ci/publish
View file
Open in desktop
Expand Up @@ -10,9 +10,6 @@ set -eux
# branch of jupyterhub/helm-chart. We have installed a private SSH key within
# the ~/.ssh folder with permissions to push to jupyterhub/helm-chart.
if [[ $GITHUB_REF != refs/tags/* ]]; then
# Using --long, we are ensured to get a build suffix, which ensures we don't
# build the same tag twice.
#
# Using --extra-message, we help readers of merged PRs to know what version
# they need to bump to in order to make use of the PR. This is enabled by a
# GitHub notificaiton in the PR like "Github Action user pushed a commit to
Expand All @@ -29,7 +26,7 @@ if [[ $GITHUB_REF != refs/tags/* ]]; then
PR_OR_HASH=$(git log -1 --pretty=%h-%B | head -n1 | sed 's/^.*\(#[0-9]*\).*/\1/' | sed 's/^\([0-9a-f]*\)-.*/@\1/')
LATEST_COMMIT_TITLE=$(git log -1 --pretty=%B | head -n1)
EXTRA_MESSAGE="${GITHUB_REPOSITORY}${PR_OR_HASH} ${LATEST_COMMIT_TITLE}"
chartpress --push --publish-chart --long --extra-message "${EXTRA_MESSAGE}"
chartpress --push --publish-chart --extra-message "${EXTRA_MESSAGE}"
else
# Setting a tag explicitly enforces a rebuild if this tag had already been
# built and we wanted to override it.
Expand Down