upload chart as github artifact #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- runs publish workflow for push and pull request - moves credential-requiring conditions to individual steps instead of workflow as a whole - on pull request, upload as artifact instead of publishing to the chart repository This will only fully work if there are no changes to images
manics
reviewed
Mar 8, 2021
uses step output for central single variable since it's a derived value that we check several times
minrk
commented
Mar 8, 2021
|
|
||
| # ref: https://github.com/actions/upload-artifact | ||
| - uses: actions/upload-artifact@v2 | ||
| if: steps.publishing.outputs.publishing == '' |
There was a problem hiding this comment.
Weird possible bug in actions: cannot use simpler if: !steps.publishing.outputs.publishing which produces a syntax error, when I'm pretty sure it should be fine.
minrk
commented
Mar 8, 2021
|
Thank you @minrk! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only fully work if there are no changes to images in the PR, since image upload won't happen without credentials.
closes #2043