Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub image: run apt-get upgrade by default to patch known vulns #2304

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jul 5, 2021

The official ubuntu image that we use as a base image for hub isn't updated so often, but various libraries in ubuntu are updated more often, where they also quite often have fixes to known vulnerabilities in them.

We have a system to detect if rebuilding the image fixes some known vulnerabilities, but in practice it requires a new ubuntu image to have been released - which is too seldom. So perhaps its worth doing apt-get upgrade -y to patch some known vulnerabilities in between the ubuntu image is updated?

Image size?

I observed the image size grow from 625 to 631 which I assume is because some packages were upgraded, but overall it doesn't seem to make it grow substantially so I think this is worth it to more or less always end up with no known vulnerabilities whenever we rebuild the image.

Fixes known vulns?

I confirmed with trivy that doing this fixed known vulns that is observed for example in #2269 to be unfixed after a rebuild.

@consideRatio
Copy link
Member Author

I'll go ahead and self-merge this, I'm just too curious to see if this resolves the vulnerability scanning troubles observed.

@consideRatio consideRatio merged commit adda42a into jupyterhub:main Jul 6, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 6, 2021
@consideRatio
Copy link
Member Author

Okay @yuvipanda @manics this fixes known vulnerbilities as intended - but is it acceptable to be living on the bleeding edge like this instead of using the versions shipped in the ~monthly built ubuntu image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant