Add support for arm64 in singleuser-sample image #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jul 17, 2021
jupyterhub/zero-to-jupyterhub-k8s#2316 Merge pull request #2316 from consideRatio/pr/support-arm64
|
I checked release helm repo update
helm upgrade \
--cleanup-on-fail \
--install jhub jupyterhub/jupyterhub \
--namespace jupyterhub \
--create-namespace \
--version 1.0.1-n043.he0658ec0 \
--values jupyter-hub-config.yamlIt seems to work perfectly. Great work. |
|
Wieee thank you @sakuraiyuta!!! |
|
I'm so stoked for this changes, thanks everyone :) Now I can delete a bunch of custom hacks I have in my own repos :D Y'all rock :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of a lot of work in jupyter/docker-stacks surrounding jupyter/docker-stacks#1019!
Thank you everyone involved! Thank you @sakuraiyuta, @holdenk, @mathbunnyru, @manics, @jiwidi, @parente, @AvverbioPronome, @step21, @akitanaka, and @romainx!
It makes me very happy to finally get the JupyterHub Helm chart 100% arm64 compatible!
Closes #2145
Update 1
This PR can't be merged until jupyter/docker-stacks#1411 is resolved sadly.
Update 2
Wait what... the singleuser-sample could build without an arm64 compatible image was published? I'm not sure why that is... @manics do you think jupyter/docker-stacks#1368 was sufficient? I'm very confused why the build of our singleuser-sample with arm64 succeeded if has a FROM statement from an image that doesn't list arm64 in its manifest.
Why did https://github.com/jupyterhub/zero-to-jupyterhub-k8s/runs/3090822567 not fail!?
Update 3
I'm still very confused: why was it possible for our singleuser-sample to build an arm64 image from a Dockerfile that had a FROM statement referencing an amd64 image?
No matter what though, I'll go for a merge now, because we now have arm64 compatible images pushed and when retriggering the tests they still succeed.
Conclusion
If anyone can verify that this Helm chart can install and run the default user image on a arm64 based k8s, that would be great! This probably works, but does it really?