Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update shellcheck #2420

Merged
merged 4 commits into from Oct 14, 2021
Merged

Conversation

consideRatio
Copy link
Member

No description provided.

@manics
Copy link
Member

manics commented Sep 30, 2021

The CI job claims there was nothing to check https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2420/checks?check_run_id=3757298365
which means the new shellcheck version wasn't tested:

 [INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
Shellcheck Bash Linter...............................(no files to check)Skipped

@consideRatio
Copy link
Member Author

consideRatio commented Oct 1, 2021

@manics I manually installed latest shellcheck binary and trialed the latest pre-commit-hook version wrapping the use of that binary. Everything works after small patches.

I also noted that it was weird that we ran shellcheck as a pre-commit hook related to a job focused on linting helm templates. Due to that, I extracted it to a dedicated job specific to script files.

@consideRatio consideRatio added the ci label Oct 1, 2021
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
@consideRatio
Copy link
Member Author

Shellcheck is now run correctly, going for a merge as its a trivial CI PR and I think this is fine at this point.

@consideRatio consideRatio merged commit 7a6b364 into jupyterhub:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants